Bring back NetTopologySuite plugin #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YohDeadfall
suggested changes
Aug 28, 2019
....PG.NTS/Query/ExpressionTranslators/Internal/NpgsqlNetTopologySuiteMemberTranslatorPlugin.cs
Outdated
Show resolved
Hide resolved
....PG.NTS/Query/ExpressionTranslators/Internal/NpgsqlNetTopologySuiteMemberTranslatorPlugin.cs
Outdated
Show resolved
Hide resolved
....PG.NTS/Query/ExpressionTranslators/Internal/NpgsqlNetTopologySuiteMemberTranslatorPlugin.cs
Show resolved
Hide resolved
....PG.NTS/Query/ExpressionTranslators/Internal/NpgsqlNetTopologySuiteMemberTranslatorPlugin.cs
Show resolved
Hide resolved
...NTS/Query/ExpressionTranslators/Internal/NpgsqlNetTopologySuiteMethodCallTranslatorPlugin.cs
Outdated
Show resolved
Hide resolved
...NTS/Query/ExpressionTranslators/Internal/NpgsqlNetTopologySuiteMethodCallTranslatorPlugin.cs
Outdated
Show resolved
Hide resolved
...NTS/Query/ExpressionTranslators/Internal/NpgsqlNetTopologySuiteMethodCallTranslatorPlugin.cs
Show resolved
Hide resolved
Member
Author
|
@YohDeadfall made the changes. @smitpatel and @maumar confirmed that the unneeded null check is indeed expected (the same happens in SQL Server). Let's leave the SQL assertions commented out for now - this will be fixed post-3.0, and now that there's no client evaluation the SQL assertions are less critical anyway. |
Now that Npgsql.NetTopologySuite has been ported to NTS 2.0.0 Fixes #835
YohDeadfall
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Npgsql.NetTopologySuite has been ported to NTS 2.0.0
Fixes #835
Note: most SQL assertions in tests have been disabled as some odd redundant null semantics checks are being introduced. I'll hold off on merging until making sure with the team that this is the intentional (for the moment).